Help texts, improve contrast and better UX writing for a11y#8052
Merged
Help texts, improve contrast and better UX writing for a11y#8052
Conversation
stevepiercy
requested changes
Mar 25, 2026
packages/volto/src/components/manage/Sharing/__snapshots__/Sharing.test.jsx.snap
Show resolved
Hide resolved
stevepiercy
approved these changes
Mar 26, 2026
Collaborator
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
Looks good, except unit tests fail because you need to update the snapshots to include that trailing period.
wesleybl
requested changes
Mar 29, 2026
wesleybl
reviewed
Mar 31, 2026
wesleybl
approved these changes
Apr 7, 2026
Member
wesleybl
left a comment
wesleybl
left a comment
There was a problem hiding this comment.
The contrast is much better now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI and Accessibility Fixes
Better Contrast - The current contrast between @secondaryBackground and @secondaryColor does not meet WCAG accessibility standards. We are increasing the color depth of the font to ensure it reaches the minimum contrast ratio required for better readability and compliance.
Accessibility First - The text needs to work for everyone, including people with vision problems. Visual icons alone are not enough for accessibility. For this reason, the text was updated to include all necessary information to assist users with visual impairments.
Safe Style Changes - Even though many of these parts use the same help class, some use their own special settings that override the default. Changing the base color to a darker shade is safe and won't break anything, even when those custom styles are active.
Technical Assessment of Affected Components
The following components implement className="help" and are being reviewed for accessibility and contrast:
Aliases.jsx
FormFieldWrapper.jsx
QueryWidget.jsx
RecurrenceWidget.jsx
Login.jsx
Issue related: #5127