Merged
Conversation
scjody
approved these changes
Aug 14, 2018
scjody
left a comment
scjody
left a comment
There was a problem hiding this comment.
I'm not sure if your inclusion of print is accidental or not. If you intend to merge it I suggest making it more detailed, and if not please remove it.
Other than that this looks good to me. 💃
| self.USERDATA_COOKIE, | ||
| self.USERNAME_COOKIE): | ||
| self._clear_cookie(response, c) | ||
| print('clear_cookies') |
| import itsdangerous | ||
| import functools | ||
|
|
||
|
|
There was a problem hiding this comment.
Not a big deal, but this shouldn't be here so if you're fixing this commit please fix this too.
T4rk1n
force-pushed
the
fix-cookies-path
branch
from
a3ec9ed to
cd18f09
Compare
T4rk1n
force-pushed
the
fix-cookies-path
branch
from
cd18f09 to
929b62f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requests_pathname_config, fix Cookie path is '/' for apps withrequests_pathname_prefix. #53.Resolve plotly/streambed#10763