Conversation
|
@scjody I tested with on-prem 2.6, the login/logout works but there is no redirect after the logout, the route just just return {} |
|
@T4rk1n Thanks for the testing. I took a look at https://github.com/plotly/dash-deployment-server/pull/190 and it doesn't look like the redirect was added. @tarzzz Can you please look into this? (Based on the design in https://github.com/plotly/streambed/issues/11817#issuecomment-439107597, a redirect is required so that |
|
@tarzzz If the redirect could take a url supplied in the form values it would be great. I could take it as prop and set hidden value input. |
|
@T4rk1n Would prefer to keep it simple at this point, to redirect to the DDS main page. It also makes sense because logging out from an app logs a user out from the DDS as well as all the other apps. We may add the redirect if it feels necessary. |
|
Getting 405 on the revoke_token route for the old logout: Invalidation failure HTTPError(u'405 Client Error: Method Not Allowed for url: https://plot.ly/Auth/o/revoke_token/',) |
Delete `DASH_LOGOUT_URL` from os.environ after logout test. Line length fix.
text attribute instead of body. Move _login flow inside try catch. Skip old logout test.
|
@scjody Please review. We decided at the last dash meeting to deprecate
I added a pending deprecation warning to The tests on circleci all get stuck with no output, they still pass locally. |
scjody
left a comment
There was a problem hiding this comment.
Looks good to me!
💃 if this works on both old (2.5.x) and new (2.6 prerelease) versions of DDS.
|
|
||
| deprecation_notice = ''' | ||
| PlotlyAuth is being deprecated. | ||
| If your app is still using dash-deployment-server < 2.6, |
There was a problem hiding this comment.
minor, but the product is called Dash Deployment Server (it's not a Python package).
| @@ -1,4 +1,5 @@ | |||
| dash_core_components | |||
| # dash_core_components | |||
| -e git+https://github.com/plotly/dash-core-components.git@logout-btn#egg=dash_core_components | |||
There was a problem hiding this comment.
Reminder to change this before merging if possible
|
Tested on 2.5 and 2.6, both works. |
DASH_LOGOUT_URLenvironment variable is set.PlotlyAuth.create_logout_buttonreturns adcc.LogoutButtonwith theDASH_LOGOUT_URLif set.Tests are still failing with timeouts.