Skip to content

DDS 3.0.0 integrations#1

Merged
scjody merged 10 commits intomasterfrom
dev
Jan 16, 2019
Merged

DDS 3.0.0 integrations#1
scjody merged 10 commits intomasterfrom
dev

Conversation

@T4rk1n
Copy link
Copy Markdown
Contributor

@T4rk1n T4rk1n commented Dec 3, 2018

Adapted from plotly/dash-auth#75

  • create_logout_button
  • get_user_data
  • get_username
  • get_kerberos_ticket_cache

@T4rk1n T4rk1n requested a review from bpostlethwaite December 3, 2018 18:04
@T4rk1n T4rk1n mentioned this pull request Dec 3, 2018
Merged
1 task
@T4rk1n
Copy link
Copy Markdown
Contributor Author

T4rk1n commented Jan 4, 2019 •
edited by scjody
Loading

Manual tests onprem-300:

  • create_logout_button
  • get_username
  • get_user_data
  • get_kerberos_ticket_cache

@T4rk1n T4rk1n changed the title DDS 2.6 integrations DDS 3.0.0 integrations Jan 4, 2019
@scjody
Copy link
Copy Markdown

scjody commented Jan 16, 2019

I tested get_kerberos_ticket_cache with https://github.com/plotly/dash-deployment-server-kerberos on etest (there isn't a Kerberos server easily available foronprem-300) and checked off the box above. I'll review this PR now.

@scjody scjody requested review from scjody and removed request for bpostlethwaite January 16, 2019 20:32
scjody
scjody approved these changes Jan 16, 2019
View reviewed changes
Copy link
Copy Markdown

@scjody scjody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@scjody scjody merged commit 806b5c9 into master Jan 16, 2019
@scjody scjody deleted the dev branch January 16, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scjody scjody scjody approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@T4rk1n @scjody