Fix multiple file drag-and-drop in dcc.Upload - #3916
Merged
Conversation
AnnMarieW
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
July 24, 2026 15:40
KoolADE85
reviewed
Jul 27, 2026
KoolADE85
left a comment
KoolADE85
left a comment
Contributor
There was a problem hiding this comment.
Looking good! I tested on Firefox and Chrome and it works well. Just needs a CHANGELOG entry.
|
Collaborator
Author
|
@KoolADE85 Thanks for the review! I added the changlog entry. |
KoolADE85
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3671
Fixes a regression introduced in #3464
Fix drag-and-drop of multiple files in
dcc.Upload. Collect allDataTransferItementries before the first async operation to avoid losing items during drag event processing.I'm not sure how to do a test for this, but when I run it locally, this fixes the multiple file drag/drop