Skip to content

Conversation

@byronz
Copy link
Contributor

@byronz byronz commented Aug 6, 2019

improvement based on 1.1 release:

  • make the pip install robust for build jobs
  • adding artifacts based on branch and tags

this fixes #852

byron added 4 commits August 5, 2019 16:01
🔧 add artifacts step
🔧 swap artifact
🔧 remove pip job, not DRY but spaces saves time.
@byronz byronz marked this pull request as ready for review August 6, 2019 19:52
@@ -1,4 +1,4 @@
pytest<5.0.0
pytest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice when <5 came in with #808 - what's the story here? Why did you add it then, why did the restriction get removed now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue with pytest at the moment, I was looking for a candidate to trigger a cache key not found, a natural pick for the purpose.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the pytest v5 thing but that's not blocking 💃

@byronz byronz merged commit ee165d9 into master Aug 6, 2019
@byronz byronz deleted the improve-ci branch August 6, 2019 22:35
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
PersistenceTransforms for date in datePickerRange and datePickerSingle
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
PersistenceTransforms for date in datePickerRange and datePickerSingle
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the circleci

3 participants