Skip to content

Improve ci #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byronz merged 5 commits into from
Aug 6, 2019
Merged

Improve ci #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54df020
:wrench: configure ci
Aug 5, 2019
7525ebc
Aug 5, 2019
616390f
Aug 6, 2019
ba3cda8
Aug 6, 2019
a3d8305
Merge branch 'master' into improve-ci
byronz Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@ jobs:
steps:
- run: percy finalize --all

"artifacts":
docker:
- image: circleci/python:3.7-stretch-node-browsers
environment:
PYVERSION: python37
steps:
- checkout
- run: echo $PYVERSION > ver.txt
- restore_cache:
key: dep-{{ checksum "ver.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
- attach_workspace:
at: ~/dash
- store_artifacts:
path: ~/dash/packages
destination: /tmp/packages

"lint-unit-37": &lint-unit
working_directory: ~/dash
docker:
Expand Down Expand Up @@ -71,6 +87,17 @@ jobs:
- run: echo $PYVERSION > ver.txt
- restore_cache:
key: dep-{{ checksum "ver.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
- run:
name: 🚧 pip dev requirements
command: |
sudo pip install --upgrade virtualenv
python -m venv venv || virtualenv venv && . venv/bin/activate
pip install -e . -r requires-install.txt -r requires-ci.txt -r requires-testing.txt --quiet
- save_cache:
key: dep-{{ checksum "ver.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
paths:
- "venv"

- run:
name: 🚧 build core
command: |
Expand Down Expand Up @@ -112,6 +139,16 @@ jobs:
- run: echo $PYVERSION > ver.txt
- restore_cache:
key: dep-{{ checksum "ver.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
- run:
name: 🚧 pip dev requirements
command: |
sudo pip install --upgrade virtualenv
python -m venv venv || virtualenv venv && . venv/bin/activate
pip install -e . -r requires-install.txt -r requires-ci.txt -r requires-testing.txt --quiet
- save_cache:
key: dep-{{ checksum "ver.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
paths:
- "venv"
- run:
name: 🚧 build misc
command: |
Expand Down Expand Up @@ -198,6 +235,17 @@ workflows:
- "percy-finalize":
requires:
- test-37
- "artifacts":
requires:
- percy-finalize
filters:
branches:
only:
- master
- dev
tags:
only: /v*/

python3.6:
jobs:
- lint-unit-36
Expand Down
2 changes: 1 addition & 1 deletion requires-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pytest<5.0.0
pytest
Copy link
Collaborator

@alexcjohnson alexcjohnson Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice when <5 came in with #808 - what's the story here? Why did you add it then, why did the restriction get removed now?

Copy link
Contributor Author

@byronz byronz Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue with pytest at the moment, I was looking for a candidate to trigger a cache key not found, a natural pick for the purpose.

pytest-sugar
pytest-mock
lxml
Expand Down