Skip to content

ci: Add status update for upload-dev-build - #7902

Merged
camdecoster merged 4 commits into
masterfrom
cam/add-status-upload-dev-build
Jul 29, 2026
Merged

ci: Add status update for upload-dev-build#7902
camdecoster merged 4 commits into
masterfrom
cam/add-status-upload-dev-build

Conversation

@camdecoster

Copy link
Copy Markdown
Contributor

Description

Update upload-dev-build workflow to provide status update in PR checks table.

Notes

  • The upload-dev-build step only runs on PR branches that are in-repo for plotly, which means there isn't good visibility for fork PR authors
  • This change will show a step in the checks tables with messages to guide authors to contact a maintainer (though I'm not sure we should invite this kind of communication)

@camdecoster camdecoster added the no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped. label Jul 13, 2026
@camdecoster camdecoster self-assigned this Jul 15, 2026
@camdecoster camdecoster assigned emilykl and unassigned camdecoster Jul 28, 2026
Comment thread .github/workflows/upload-dev-build.yml Outdated

- name: Get required metadata (PR number, commit SHA, workflow run ID containing artifacts)
id: get-metadata
if: steps.fork-check.outputs.is_fork != 'true'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reverse this check (and all the others) so that it "fails safe" if the fork-check step doesn't set an output for any reason?

Suggested change
if: steps.fork-check.outputs.is_fork != 'true'
if: steps.fork-check.outputs.is_fork == 'false'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one comment. Otherwise LGTM.

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@camdecoster
camdecoster merged commit aad9b94 into master Jul 29, 2026
79 of 80 checks passed
@camdecoster
camdecoster deleted the cam/add-status-upload-dev-build branch July 29, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants