fix: Improve handling of auto-fitting with many features and the antimeridian on geo traces - #7948
Merged
Merged
Conversation
emilykl
reviewed
Aug 7, 2026
| * @param {object} trace - a `fullData` trace | ||
| * @param {object} geoLayout - the subplot's `fullLayout` entry | ||
| * @return {Array|null} `[west, south, east, north]`, or null whenever | ||
| * `fitGeojsonCoords` is empty — in which case the caller falls back to the data. |
Contributor
There was a problem hiding this comment.
I don't like this pattern of describing what the calling function will do. The docstring should document this function's behavior, not the behavior of the calling function.
Suggested change
| * `fitGeojsonCoords` is empty — in which case the caller falls back to the data. | |
| * `fitGeojsonCoords` is empty. |
emilykl
reviewed
Aug 7, 2026
Contributor
There was a problem hiding this comment.
From a data-visualization perspective, probably better to turn off auto-fitting for this mock.
camdecoster
marked this pull request as ready for review
August 7, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve handling of geo trace auto-fitting with multiple features and geometry that crosses the antimeridian.
Closes #7943.
Changes
Screenshots
Testing
Notes
getAutoRange