Geo fixes #660
Geo fixes #660
Conversation
dmt0
force-pushed
the
geo-fixes
branch
5 times, most recently
from
e0715d3 to
e3e5d38
Compare
| super(props, context); | ||
| const {localize: _} = context; | ||
|
|
||
| // Replicated so that strings can be statically analyzed for localization |
There was a problem hiding this comment.
why is replication needed?
There was a problem hiding this comment.
My guess was that there's a script that does static analysis of the code and adds strings to the translation files, so this thing needs to live inside a component. Tried putting it in one and accessing from another - like UnconnectedFilterValue.operation - no luck. What's the way?
There was a problem hiding this comment.
you could make it a function? and pass in localize as a prop?
| <Numeric label={_('Scale')} attr="projection.scale" min={0} /> | ||
| </PlotlySection> | ||
|
|
||
| <PlotlySection name={_('Map Rotation')}> |
There was a problem hiding this comment.
I would key frame and rotation at the bottom, personally. not sure if anyone knows enough math to actually edit the rotation numbers tho
There was a problem hiding this comment.
it's there in cloud ya know, and I thought to put all relevant things together, everything below has to do with map contents...
There was a problem hiding this comment.
yeah let's make map contents the top stuff please, and leave the weird stuff at the bottom
There was a problem hiding this comment.
OK but the region and projection should stay at the top :) the Frame and Rotation and Scale and Resolution should be at the bottom :)
|
not sure the error messages really need to be localized, but I appreciate the thoroughness :) |
|
no idea what percy is doing, I see all panels just fine locally |
| attr="resolution" | ||
| options={[ | ||
| {label: _('1:110,000,000'), value: 110}, | ||
| {label: _('1:50,000,000'), value: 50}, |
There was a problem hiding this comment.
that label title is a little weird no?
There was a problem hiding this comment.
that's what is in cloud - most importantly it will be translated to all languages :)
|
💃 on the code |
|
💃 once "map region" is back at the top :) |
|
err hang on, weirdness in Percy. |
src/default_panels/StyleAxesPanel.js
Outdated
| /> | ||
| <Numeric label={_('Thickness')} attr="gridwidth" units="px" /> | ||
| <ColorPicker label={_('Color')} attr="gridcolor" /> | ||
| <Numeric label={_('Reference')} attr="tick0" units="deg" /> |
There was a problem hiding this comment.
these are problematic because they share attr names with other stuff in cartesian!
There was a problem hiding this comment.
do a search for dtick and you'll see
There was a problem hiding this comment.
see also #535 which is the same-ish issue: attrs with the same name in different trace-type/axes that should have different labels/treatment
geo fixes: