feat(parser): rework diagnostics and harden parser for v1#413
Merged
Conversation
zharinov
enabled auto-merge (squash)
June 12, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser/: remove dead API surface, restore lossless-CST guarantees, drop allocations in hot paths, correct misleading lexer comments (verified against vendored logos/rowan/annotate-snippets sources)Why
Pre-v1 cleanup so upcoming syntax extensions land on a solid base. Strict snake_case captures chosen deliberately: capture names become Rust struct fields under the planned proc-macro compilation.
Notes
render/render_coloredare now filtered,render_unfilteredkept for debugging(a) @Namesuggested(a) name); all patches now substitute the annotated range verbatimUnclosedStringranks above other unclosed kinds: a missing quote swallows closing delimiters, so it is the root cause