refactor(anchors): extract shared anchor-lowering truth into analyze/anchors.rs#527
Merged
Conversation
The padding-step disassembly line emitted a trailing space after the `...` marker. Trim it so golden fixtures carry no trailing whitespace. Pure formatting: regenerates the affected emit/vm golden fixtures.
…anchors.rs Codegen's sibling-gap and trailing-anchor navigation logic moved into a single `analyze/anchors.rs` so there is one place that decides what an anchor lets a sibling gap skip. The VM cursor and the Thompson lowering passes now read their skip decisions from the shared `NodeClass`/`SkipClass` vocabulary in `core`. Pure refactor: no emitted-bytecode changes.
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/plotnik-lib/src/compiler/analyze/anchors.rs.NodeClass/SkipClassvocabulary incore.Why
Anchor skip rules were spelled out in more than one place. One source of truth keeps the VM and codegen from drifting apart.
Notes
Pure refactor. No emitted-bytecode changes and no fixture changes.