fix(diagnostics): clearer wording, coalesced recovery, accurate capture sites#534
Merged
Conversation
…re sites
- Parser recovery groups a run of stray tokens into one error node and one
diagnostic instead of one per token; a missing ) ] } reports a uniform
"unclosed" message via expect_close.
- Reworded several type/shape error headlines into plain language.
- capture_sites no longer flags captures inside nested scopes like {...} @Row,
and the suggested row-capture name skips names already bound in scope.
- run/trace default to the last definition when --entry is omitted.
zharinov
enabled auto-merge (squash)
June 29, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(...),[...], or{...}collapses into one error instead of one per token.),], or}reports one uniform "unclosed" message.a repeated capture must be collected into a list.{...} @row. The suggested row-capture name also skips names already used nearby.runandtraceuse the last definition when--entryis omitted.Why
Some diagnostics read like internal jargon, two pointed at the wrong code, and a query with several definitions errored instead of running its last one.
Notes
docs/lang-reference.mdand covered by a CLI test.fuzz_no_panic.proptest-regressionspins a parser input (("¡;) that the recovery change fixed.