test: rewrite golden fixture suite#544
Merged
Merged
Conversation
Mislabeled fixtures rewritten or renamed to pin what their names claim, unintended diagnostics removed, entrypoint naming and style-guide formatting violations corrected.
Kahn's sort dropped multi-node dependency cycles, so nothing in a mutual-recursion cycle (or downstream of it) got declared and each entrypoint fell back to `export type X = X;`. When the ready queue runs dry with types still pending, force out a type another pending type waits on and continue the drain.
zharinov
enabled auto-merge (squash)
July 5, 2026 05:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser, analyze, emit, typegen, vm).
alternations,anchors,captures,definitions,fields,nodes,predicates,quantifiers,recursion,sequences.instead of self-aliases like
export type Obj = Obj.Why
Golden fixtures are the primary test suite and double as a living spec. One
shared layout makes fixtures easy to find and keeps coverage consistent across
stages. Each fixture pins current compiler behavior.
Notes
typegen/typescript/analysis.rs(the cyclefix). Everything else is fixtures.
**/,(MISSING ...)runs without a missing-node check). Those stay pinnedand are fixed separately.