test: Eliminate redundant work from test runs#567
Merged
Conversation
zharinov
marked this pull request as ready for review
July 12, 2026 03:37
zharinov
enabled auto-merge (squash)
July 12, 2026 03:37
zharinov
disabled auto-merge
July 12, 2026 03:40
zharinov
enabled auto-merge (squash)
July 12, 2026 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A warm
make testtook about 101 seconds even though the same workspace completed near 32 seconds with shared-process execution. The gap came from work that Nextest's process-per-test model amplified: grammar fixtures launchedcargo metadataat runtime, all-language invariants rebuilt the same grammars in separate processes, and two generated-Rust suites launched competing rustc jobs.This change removes that redundant work while keeping Nextest and its per-test isolation:
plotnik-tests/build.rsand embed their grammar JSON in test artifacts. A representative isolated VM fixture fell from 233 ms to 62.6 ms.OnceLockcaches are effective. Their failures are still aggregated, and both former filter names continue to select the combined test.trybuildprogram. Conformance helpers live under a unique crate-root module so they cannot accidentally satisfy imports emitted by a broken generator.On the same checkout, warmed full-suite runs fell from 101.0 seconds to 34.5–39.0 seconds, with all 1,606 Nextest trials passing. A shared-process comparison completed in 31.6 seconds, leaving too little runner-specific upside to justify giving up Nextest's isolation and reporting.