test: Make property tests enforce witnessed outcomes#587
Merged
Conversation
zharinov
marked this pull request as ready for review
July 16, 2026 01:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old end-to-end property tests could pass even when no query completed successfully. Rejection,
NoMatch, and VM limit errors were all accepted outcomes. The tests could catch crashes, but not wrong results.What passes now
The suite has two jobs:
Expected values and byte spans come from the input generator, not from the syntax tree used by the VM. Original and formatted queries must infer the same types and return the same result.
The valid cases cover captures, repeated records, labeled alternatives, recursion, discarded results, and field predicates.
Parser bug uncovered by the formatter property
The input
(("("produced a legacy-syntax warning at the same position as its missing-closing-delimiter error. Diagnostic deduplication kept the warning and dropped the error, so the formatter received an incomplete recovery tree and hit an assertion.EOF recovery now keeps the missing-delimiter error. Query checking rejects the input, and formatting returns
FormatError::Parse.Valid queries and result formats are unchanged.