feat: Harden invariant discipline and remove redundant tests#595
Merged
Conversation
zharinov
changed the title
zharinov
marked this pull request as ready for review
July 18, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotnik now distinguishes failures by where they originate. Invalid queries, I/O failures, format limits reached by user-supplied data, and runtime capacity exhaustion remain
Resultor diagnostic paths. Once input has passed validation, missing artifacts, invalid indexes, inconsistent graph state, and impossible enum cases are treated as programmer errors. The change replaces silent fallbacks and debug-only checks with unconditional assertions carrying local context, and makes enum policy matches exhaustive so future variants cannot inherit behavior accidentally.The same cleanup removes low-level unit tests that duplicate the retained snapshot, compile-diagnostic, fuzz, and integration suites. Their test-only helpers, module declarations, and dependencies are removed with them. Public query and bytecode formats remain unchanged.