refactor: share matcher verification#601
Merged
Merged
Conversation
zharinov
marked this pull request as ready for review
July 18, 2026 18:09
zharinov
enabled auto-merge (squash)
July 18, 2026 18:09
zharinov
disabled auto-merge
July 18, 2026 18:09
zharinov
enabled auto-merge (squash)
July 18, 2026 18:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the compiler and bytecode loader's parallel matcher verifiers with one representation-neutral verifier. Bytecode format, emitted instructions, generated Rust output, and runtime entrypoint selection remain unchanged. A single artifact still exposes every selectable definition and can run any of them. No caller changes are required.
Previously, each representation maintained its own graph walk for the same matcher invariants. Changes had to be implemented twice, which allowed the two acceptance paths to drift. The shared verifier now defines that contract once.
Both stages project into the same normalized
Programmodel, with responsibility divided at these boundaries:Empty-path cursor-read analysis remains a semantic-stage check because emitted targets have already passed that trust boundary. Verification failures still map to the existing
SemanticVerifyErrorandModuleErrortypes.Bytecode and generated Rust snapshots remain unchanged. A module containing two selectable definitions successfully ran either named entrypoint, and the 4,096-entry regression retained linear verification behavior.