refactor(codegen): single-source matcher fields#617
Merged
Conversation
zharinov
enabled auto-merge (squash)
July 19, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matcher planning kept every grammar field twice: the first-appearance
fieldslist for Rust identifier assignment and an ID-sortedexpected_fieldslist for runtime language verification. Both owned the same IDs and names.Keep
fieldsas the canonical metadata. The builder now indexes that list by field ID and reuses the stored plan on repeated checks. Rust emission sorts a temporary borrowed view only when producingEXPECTED_FIELDS, preserving generated order without retaining a second collection.