Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/wacky-spoons-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"webtools-addon-sitemap": patch
"strapi-plugin-webtools": patch
---

fix: incorrect sitemap generation during auto/bulk generation
4 changes: 3 additions & 1 deletion packages/addons/sitemap/server/middlewares/auto-generate.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ const autoGenerateMiddleware = async (context, next) => {
const document = await next();

// Generate the sitemap.
getPluginService('core').createSitemap('default');
setTimeout(() => {
getPluginService('core').createSitemap('default');
}, 0);

// Return the document
return document;
Expand Down
36 changes: 29 additions & 7 deletions packages/core/server/services/bulk-generate.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { UID } from '@strapi/strapi';
import { UID, Data } from '@strapi/strapi';

import { getPluginService } from '../util/getPluginService';
import { GenerationType } from '../types';
Expand Down Expand Up @@ -82,9 +82,20 @@ const generateUrlAliases = async (params: GenerateParams): Promise<number> => {
});

// eslint-disable-next-line no-await-in-loop
await strapi.db.query(type as 'api::test.test').updateRelations(entity.id, {
url_alias: [newUrlAlias.id],
});
const allItems = await strapi.db.query(type as 'api::test.test').findMany({
where: {
...(entity.locale ? { locale: entity.locale } : {}),
document_id: entity.documentId,
},
}) as Data.ContentType[];

// eslint-disable-next-line no-restricted-syntax
for (const doc of allItems) {
// eslint-disable-next-line no-await-in-loop
await strapi.db.query(type as 'api::test.test').updateRelations(doc.id, {
url_alias: [newUrlAlias.id],
});
}

// eslint-disable-next-line no-await-in-loop
await Promise.all(entity.localizations.map(async (loc) => {
Expand All @@ -103,9 +114,20 @@ const generateUrlAliases = async (params: GenerateParams): Promise<number> => {
});

// eslint-disable-next-line no-await-in-loop
await strapi.db.query(type as 'api::test.test').updateRelations(loc.id, {
url_alias: [alias.id],
});
const allLocalizations = await strapi.db.query(type as 'api::test.test').findMany({
where: {
...(loc.locale ? { locale: loc.locale } : {}),
document_id: loc.documentId,
},
}) as Data.ContentType[];

// eslint-disable-next-line no-restricted-syntax
for (const doc of allLocalizations) {
// eslint-disable-next-line no-await-in-loop
await strapi.db.query(type as 'api::test.test').updateRelations(doc.id, {
url_alias: [alias.id],
});
}
}));

generatedCount += 1;
Expand Down
Loading