fix(hidden-question): Adding string condition handlers for hidden question type - #40
Merged
Merged
Conversation
ccailly
force-pushed
the
fix/hidden-question-string-condition-handlers
branch
from
August 3, 2026 12:50
c379d0f to
c043428
Compare
ccailly
marked this pull request as ready for review
August 3, 2026 12:51
RomainLvr
approved these changes
Aug 3, 2026
Rom1-B
reviewed
Aug 3, 2026
ccailly
force-pushed
the
fix/hidden-question-string-condition-handlers
branch
from
August 3, 2026 13:27
c043428 to
382b9e2
Compare
The condition handlers added to HiddenQuestion were not covered by any test. Add a test case based on the core AbstractConditionHandlerTest, which evaluates every operator supported by StringConditionHandler on a hidden question and checks that the question type exposes them. Extract the configurable items helpers of AdvancedFormsTestCase into a trait, as a test case extending a core abstract test case can't extend AdvancedFormsTestCase but still needs to enable the tested question type. Also add the missing changelog entry for the fix itself.
ccailly
force-pushed
the
fix/hidden-question-string-condition-handlers
branch
from
August 3, 2026 13:29
382b9e2 to
dec2f9b
Compare
Rom1-B
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
This pull request enhances the
HiddenQuestiontype to support being used as a criteria in form conditions and adds support for string-based condition handling.