Drop not injectable fields before single linkfield workaround#260
Merged
cedric-anne merged 2 commits intopluginsGLPI:developfrom Mar 17, 2022
Merged
Drop not injectable fields before single linkfield workaround#260cedric-anne merged 2 commits intopluginsGLPI:developfrom
cedric-anne merged 2 commits intopluginsGLPI:developfrom
Conversation
cedric-anne
approved these changes
Mar 1, 2022
This was referenced Mar 1, 2022
Contributor
Author
|
Last commit addresses issue where the plugin tried searching for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since glpi-project/glpi#8816, there was a second search option with the same "users_id" link field. Then in the workaround for #121, the correct
Useroption gets removed and theAppliance Useroption remains. This remaining option isn't injectable though and is dropped later anyways. It makes sense to drop all non-injectable options before the workaround.fixes #259
fixes #243
fixes #233