Skip to content

Solve PLR0917 errors - #478

Merged
bouwew merged 1 commit into
mainfrom
PLR0917
Aug 2, 2026
Merged

Solve PLR0917 errors#478
bouwew merged 1 commit into
mainfrom
PLR0917

Conversation

@bouwew

@bouwew bouwew commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor

    • Updated sleep and temperature/humidity configuration requests to use explicit named settings.
    • Existing configuration behavior and serialized request output remain unchanged.
  • Tests

    • Updated coverage to reflect the revised configuration request syntax.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@bouwew, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d52e4d3d-d0d6-4f80-a0c2-16bf324e734f

📥 Commits

Reviewing files that changed from the base of the PR and between 9f63a31 and 6d6dda0.

📒 Files selected for processing (4)
  • plugwise_usb/messages/requests.py
  • plugwise_usb/nodes/sed.py
  • plugwise_usb/nodes/sense.py
  • tests/test_usb.py
📝 Walkthrough

Walkthrough

The request constructors now enforce keyword-only configuration arguments. SED and sensor configuration call sites, plus the related test, pass the same values by keyword.

Changes

Request configuration

Layer / File(s) Summary
Keyword-only constructor contracts
plugwise_usb/messages/requests.py
NodeSleepConfigRequest and SenseConfigureHysteresisRequest require configuration arguments after send_fn and mac to use keyword syntax.
Updated configuration call sites
plugwise_usb/nodes/sed.py, plugwise_usb/nodes/sense.py, tests/test_usb.py
SED, humidity, temperature, and test request construction uses explicit keyword arguments with unchanged values.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: dirixmjm, arnoutd

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: addressing PLR0917 errors by making constructor arguments keyword-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PLR0917

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested review from ArnoutD and dirixmjm August 2, 2026 17:57
@sonarqubecloud

sonarqubecloud Bot commented Aug 2, 2026

Copy link
Copy Markdown

@bouwew
bouwew marked this pull request as ready for review August 2, 2026 18:02
@bouwew
bouwew requested a review from a team as a code owner August 2, 2026 18:02
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (f847831) to head (6d6dda0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   81.79%   81.78%   -0.02%     
==========================================
  Files          36       36              
  Lines        8192     8192              
==========================================
- Hits         6701     6700       -1     
- Misses       1491     1492       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouwew
bouwew merged commit aebfb1a into main Aug 2, 2026
16 of 17 checks passed
@bouwew
bouwew deleted the PLR0917 branch August 2, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant