Skip to content

Better NetNS parallel access#69

Merged
msagheer merged 1 commit into
masterfrom
nsparalel
Oct 1, 2016
Merged

Better NetNS parallel access#69
msagheer merged 1 commit into
masterfrom
nsparalel

Conversation

@eduser25

Copy link
Copy Markdown

I think GO is doing something fuzzy when lockOSthread is called,
and the goroutine sleeps. This should avoid a goroutine to lock the thead
and sleep, forcing the routine to always unlock the thread prior going
to sleep, allowing other routines to reuse the thread.

Tested it with 1-shot 90 container onboard, no issues seen.

Signed-off-by: eduards eduards@plumgrid.com

Conflicts:

plugin/driver/driver.go

Signed-off-by: eduards eduards@plumgrid.com

I think GO is doing something fuzzy when lockOSthread is called,
and the goroutine sleeps. This should avoid a goroutine to lock the thead
and sleep, forcing the routine to always unlock the thread prior going
to sleep, allowing other routines to reuse the thread.

Tested it with 1-shot 90 container onboard, no issues seen.

Signed-off-by: eduards <eduards@plumgrid.com>

Conflicts:

	plugin/driver/driver.go

Signed-off-by: eduards <eduards@plumgrid.com>

@msagheer msagheer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msagheer
msagheer merged commit 79b8a55 into master Oct 1, 2016
@JaveriaK
JaveriaK deleted the nsparalel branch October 13, 2016 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants