Skip to content

add --all flag to plural destroy#359

Merged
zreigz merged 3 commits into
mainfrom
destroy-all-flag
Mar 6, 2023
Merged

add --all flag to plural destroy#359
zreigz merged 3 commits into
mainfrom
destroy-all-flag

Conversation

@michaeljguarino

@michaeljguarino michaeljguarino commented Mar 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

This will make a full cluster destroy require an implicit invocation which can prevent mistyping

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Mar 3, 2023
@michaeljguarino
add --all flag to plural destroy
057d2bd 
This will make a full cluster destroy require an implicit invocation which can prevent mistyping
@michaeljguarino
try to enable services when some are missing
573ce9f
zreigz
zreigz approved these changes Mar 6, 2023
View reviewed changes

@zreigz zreigz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zreigz zreigz merged commit 557968d into main Mar 6, 2023
michaeljguarino added a commit that referenced this pull request Aug 28, 2024
@michaeljguarino
add --all flag to plural destroy (#359)
dcd4741 
* add `--all` flag to plural destroy

This will make a full cluster destroy require an implicit invocation which can prevent mistyping

* try to enable services when some are missing

* Add ability to ignore preflight checks
kinjalh pushed a commit that referenced this pull request Jun 3, 2025
@michaeljguarino @kinjalh
add --all flag to plural destroy (#359)
ab9802c 
* add `--all` flag to plural destroy

This will make a full cluster destroy require an implicit invocation which can prevent mistyping

* try to enable services when some are missing

* Add ability to ignore preflight checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zreigz zreigz zreigz approved these changes
@davidspek davidspek Awaiting requested review from davidspek

Assignees

No one assigned

Labels

enhancement New feature or request roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaeljguarino @zreigz @swoodward90