Skip to content

Don't use crap go yaml parser#501

Merged
michaeljguarino merged 1 commit into
mainfrom
fix-values-arg
Apr 1, 2024
Merged

Don't use crap go yaml parser#501
michaeljguarino merged 1 commit into
mainfrom
fix-values-arg

Conversation

@michaeljguarino

Copy link
Copy Markdown
Member

Summary

Nested objects become map[interface{}]interface{} which fails to then be json encoded, use k8s' internal one instead.

Test Plan

local

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Nested objects become map[interface{}]interface{} which fails to then be json encoded, use k8s' internal one instead.
@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug hotfix labels Apr 1, 2024
@michaeljguarino michaeljguarino merged commit c34749f into main Apr 1, 2024
@michaeljguarino michaeljguarino deleted the fix-values-arg branch April 1, 2024 21:25
michaeljguarino added a commit that referenced this pull request Aug 28, 2024
Nested objects become map[interface{}]interface{} which fails to then be json encoded, use k8s' internal one instead.
kinjalh pushed a commit that referenced this pull request Jun 3, 2025
Nested objects become map[interface{}]interface{} which fails to then be json encoded, use k8s' internal one instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This pull request fixes a bug hotfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant