Skip to content

rust-msrv builds but does not check tests, so an MSRV break in test code passes CI #200

Description

@plusky

Subtask of #169 (worth doing now, part of ranked 5).

The rust-msrv job runs cargo build only. So an MSRV break in test code or
dev-dependencies
passes CI cleanly and breaks a contributor on 1.88 the moment
they run the suite — which AGENTS.md's verification block tells them to do.

The job asserts its own toolchain correctly (#162 fixed that), so it is testing
the right compiler. It just is not compiling enough with it.

Suggested direction

cargo check --workspace --all-targets --locked in place of the build. Near-free
check over build, and the job already has a warm cache — and it covers
tests, benches and examples.

Expect it to fail the first time. If it does, that is the finding: something in
the test tree already needs a newer compiler than the declared MSRV, and the fix
is either the code or the declared rust-version, decided deliberately rather
than by accident.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ai-assistedAuthored or substantially written with an AI coding agentgithub_actionsPull requests that update GitHub Actions code

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions