Skip to content

Conversation

@Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Feb 18, 2025

TEE End to End Testing

Trying to focus on getting end to end tests that can be ran for each of our example manifests.

Native

Right now, this is just doing our example locally and we will need secrets to do tests elsewhere. The main difference between this at the moment and what we do in CI is that this checks for the client to emit "Proving Successful" so that this only passes if the proof itself finishes end to end, and not just if the client itself runs and completes.

WASM

Now we can run:

npm test tee
npm test origo

to run in different modes with playwright.

WIP TODOs

  • Get this native version working with other manifests.
  • Do this same work but with the WASM playwright tests

EDIT: These will happen in #531

@Autoparallel
Copy link
Contributor Author

This last commit does not properly assign the variable passed in and is only running in tee mode -- do not even think of merging this

@Autoparallel
Copy link
Contributor Author

4424b79 should have fixed the issue I mentioned previously.

I am still having this fail locally for me though it is running the correct mode. I did the symlinking that the workflow asked for. Will carry on a bit and focus on the TEE side with the different manifests.

@Autoparallel Autoparallel marked this pull request as ready for review February 26, 2025 18:27
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. My one question is wether or not we want to run these new tests in CI or not.

Copy link
Contributor

@mattes mattes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the time we wait until Notary is ready to accept requests.

@Autoparallel
Copy link
Contributor Author

Will handle comments today :)

Thanks guys!

@Autoparallel
Copy link
Contributor Author

This looks great to me. My one question is wether or not we want to run these new tests in CI or not.

Just made a change here. Good suggestion

@Autoparallel
Copy link
Contributor Author

Ahh.. i see now, the workflow Test Client Native with TEE is using pre-installed bins from the cache. However, I made the function in the tests use cargo run --release -p ...

Let me see if I can make this clearer.

@Autoparallel
Copy link
Contributor Author

I cannot replicate this failing test locally.

@Autoparallel
Copy link
Contributor Author

thank fucking god.

@Autoparallel Autoparallel merged commit c6942c7 into main Feb 27, 2025
22 checks passed
@Autoparallel Autoparallel deleted the feat/end-to-end-tests branch February 27, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants