-
Notifications
You must be signed in to change notification settings - Fork 5
feat: end to end tests #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now has mode for tee and origo
|
This last commit does not properly assign the variable passed in and is only running in |
|
I am still having this fail locally for me though it is running the correct mode. I did the symlinking that the workflow asked for. Will carry on a bit and focus on the TEE side with the different manifests. |
0xJepsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. My one question is wether or not we want to run these new tests in CI or not.
mattes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for the time we wait until Notary is ready to accept requests.
|
Will handle comments today :) Thanks guys! |
Just made a change here. Good suggestion |
|
Ahh.. i see now, the workflow Let me see if I can make this clearer. |
|
I cannot replicate this failing test locally. |
|
thank fucking god. |
TEE End to End Testing
Trying to focus on getting end to end tests that can be ran for each of our example manifests.
Native
Right now, this is just doing our example locally and we will need secrets to do tests elsewhere. The main difference between this at the moment and what we do in CI is that this checks for the client to emit
"Proving Successful"so that this only passes if the proof itself finishes end to end, and not just if the client itself runs and completes.WASM
Now we can run:
to run in different modes with playwright.
WIP TODOs
EDIT: These will happen in #531