Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Merge stable-1.6 into stable-1.7#1128

Merged
lukaszstolarczuk merged 18 commits intopmem:stable-1.7from
lukaszstolarczuk:merge-stable-1.6-into-stable-1.7
Jul 6, 2021
Merged

Merge stable-1.6 into stable-1.7#1128
lukaszstolarczuk merged 18 commits intopmem:stable-1.7from
lukaszstolarczuk:merge-stable-1.6-into-stable-1.7

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Jul 6, 2021

This change is Reviewable

lukaszstolarczuk and others added 18 commits October 8, 2020 15:52
it makes more sense to rebuild dockers all the time on stable branches,
because we don't have to count on DockerHub's policy to keep our
docker images on their servers.
…r-on-stables

add "rebuild" param to utils' script, to force dockers rebuilding
…nto-stable-1.6

Merge back stable-1.5 to stable-1.6
Casting unaligned ptr_offset_magic address to pointers is undefined
behavior for types which require alignemnt > 1. It results in following
error under UBSAN for ptr_0_none test:

"runtime error: upcast of misaligned address 0x0000deadbeef for type 'C',
which requires 8 byte alignment"

Also, add test for offset calculation for objects with different
alignment requirements.
…ed iterator

Origianl implementation resulted in the following array_iterator_noconv_0_test
failure under UBSAN:

"runtime error: applying non-zero offset 4 to null pointer"
Memcheck reports an error in libunwind exception raising.
tests: add libunwind suppresion
Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 9 files reviewed, all discussions resolved

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 6, 2021

Codecov Report

Merging #1128 (710d001) into stable-1.7 (ac559e6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.7    #1128      +/-   ##
==============================================
+ Coverage       91.96%   92.00%   +0.03%     
==============================================
  Files              32       32              
  Lines            2951     2951              
==============================================
+ Hits             2714     2715       +1     
+ Misses            237      236       -1     
Flag Coverage Δ
tests_clang_debug_cpp17 63.33% <ø> (+1.26%) ⬆️
tests_gcc_debug 94.34% <100.00%> (-0.93%) ⬇️
tests_gcc_release_cpp17_no_valgrind 94.04% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nclude/libpmemobj++/detail/persistent_ptr_base.hpp 97.91% <ø> (ø)
.../libpmemobj++/experimental/contiguous_iterator.hpp 100.00% <100.00%> (ø)
.../libpmemobj++/experimental/concurrent_hash_map.hpp 93.45% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac559e6...710d001. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk merged commit 3a03019 into pmem:stable-1.7 Jul 6, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the merge-stable-1.6-into-stable-1.7 branch July 6, 2021 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants