Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

add "rebuild" param to utils' script, to force dockers rebuilding#929

Merged
igchor merged 1 commit intopmem:stable-1.5from
lukaszstolarczuk:force-rebuild-docker-on-stables
Nov 18, 2020
Merged

add "rebuild" param to utils' script, to force dockers rebuilding#929
igchor merged 1 commit intopmem:stable-1.5from
lukaszstolarczuk:force-rebuild-docker-on-stables

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Oct 8, 2020

it makes more sense to rebuild dockers all the time on stable branches,
because we don't have to count on DockerHub's policy to keep our
docker images on their servers.

this change is based on commit on master: 0c5bf91


This change is Reviewable

it makes more sense to rebuild dockers all the time on stable branches,
because we don't have to count on DockerHub's policy to keep our
docker images on their servers.
@lukaszstolarczuk lukaszstolarczuk force-pushed the force-rebuild-docker-on-stables branch from fe2c2e4 to e339032 Compare October 8, 2020 13:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2020

Codecov Report

Merging #929 into stable-1.5 will decrease coverage by 31.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           stable-1.5     #929       +/-   ##
===============================================
- Coverage       90.32%   59.31%   -31.02%     
===============================================
  Files              26      101       +75     
  Lines            1023     6697     +5674     
===============================================
+ Hits              924     3972     +3048     
- Misses             99     2725     +2626     
Flag Coverage Δ
#tests_clang_release 54.92% <ø> (-6.54%) ⬇️
#tests_gcc_debug 58.13% <ø> (-35.27%) ⬇️
#tests_gcc_release_cpp17 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/detail/pexceptions.hpp
include/libpmemobj++/pext.hpp
...lude/libpmemobj++/make_persistent_array_atomic.hpp
include/libpmemobj++/p.hpp
include/libpmemobj++/make_persistent.hpp
include/libpmemobj++/experimental/array.hpp
include/libpmemobj++/utils.hpp
include/libpmemobj++/condition_variable.hpp
include/libpmemobj++/mutex.hpp
include/libpmemobj++/detail/conversions.hpp
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac52adb...e339032. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft October 9, 2020 07:46
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review October 9, 2020 07:53
Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukaszstolarczuk
Copy link
Copy Markdown
Member Author

it's an alternative to #935 :

  • it uses "rebuild", which is already available on the master (if we choose the other option we should update other_OSes.yml to also not use this flag and rather just use build-image.sh script),
  • it requires less work after release (just add "rebuild" param in the CI workflow),
  • but it leaves dead code on the stable branches.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review October 28, 2020 10:12
@igchor igchor merged commit 3170bc7 into pmem:stable-1.5 Nov 18, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the force-rebuild-docker-on-stables branch November 18, 2020 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants