This repository was archived by the owner on Mar 22, 2023. It is now read-only.
add "rebuild" param to utils' script, to force dockers rebuilding#929
Merged
igchor merged 1 commit intopmem:stable-1.5from Nov 18, 2020
Merged
Conversation
it makes more sense to rebuild dockers all the time on stable branches, because we don't have to count on DockerHub's policy to keep our docker images on their servers.
fe2c2e4 to
e339032
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.5 #929 +/- ##
===============================================
- Coverage 90.32% 59.31% -31.02%
===============================================
Files 26 101 +75
Lines 1023 6697 +5674
===============================================
+ Hits 924 3972 +3048
- Misses 99 2725 +2626
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
KFilipek
reviewed
Oct 12, 2020
Contributor
KFilipek
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
igchor
approved these changes
Oct 12, 2020
Contributor
igchor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Member
Author
|
it's an alternative to #935 :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it makes more sense to rebuild dockers all the time on stable branches,
because we don't have to count on DockerHub's policy to keep our
docker images on their servers.
this change is based on commit on master: 0c5bf91
This change is