Conversation
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 95.02% 95.06% +0.04%
==========================================
Files 42 42
Lines 4901 4901
==========================================
+ Hits 4657 4659 +2
+ Misses 244 242 -2
Continue to review full report at Codecov.
|
a914a56 to
bf865f7
Compare
igchor
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
utils/docker/build.sh, line 87 at r1 (raw file):
# Only check cppformat on Ubuntu, since it has req. clang-format version if [ "${OS}" == "ubuntu"]; then CHECK_CPP_STYLE=ON;
nit: not sure if it's a problem but with this if we cannot disable checking CPP_STYLE for ubuntu. Maybe we should check if this variable is explicitly OFF first?
- Ubuntu 19.10 -> 20.04 - Fedora 31 -> 32
bf865f7 to
b11d009
Compare
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @igchor)
utils/docker/build.sh, line 87 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
nit: not sure if it's a problem but with this if we cannot disable checking CPP_STYLE for ubuntu. Maybe we should check if this variable is explicitly OFF first?
Done.
|
images' versions will be updated to LTS versions on all branches. This PR will be probably merged into stable-1.9 |
|
changes of this PR are covered already in #887 and we've changed approach for CHECK_CPP_STYLE (based on pmem/pmemkv@380cb14). |
This change is