Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Bump docker images versions#737

Closed
lukaszstolarczuk wants to merge 2 commits intopmem:masterfrom
lukaszstolarczuk:bump-docker-images-versions
Closed

Bump docker images versions#737
lukaszstolarczuk wants to merge 2 commits intopmem:masterfrom
lukaszstolarczuk:bump-docker-images-versions

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Apr 30, 2020

  • update Fedora to 32 and Ubuntu to 20.04
  • btw, set clang-format package to version 9.0 and run cppformat checks only on Ubuntu (because clang-format-9 on Fedora is not easily accessible)

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2020

Codecov Report

Merging #737 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   95.02%   95.06%   +0.04%     
==========================================
  Files          42       42              
  Lines        4901     4901              
==========================================
+ Hits         4657     4659       +2     
+ Misses        244      242       -2     
Flag Coverage Δ
#tests_clang_debug_cpp17 95.02% <ø> (-0.03%) ⬇️
#tests_gcc_debug 91.49% <ø> (+0.18%) ⬆️
Impacted Files Coverage Δ
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.67% <0.00%> (+0.10%) ⬆️
...j++/container/detail/concurrent_skip_list_impl.hpp 97.56% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f10eb...b11d009. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk force-pushed the bump-docker-images-versions branch from a914a56 to bf865f7 Compare May 25, 2020 11:49
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review May 25, 2020 11:50
Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


utils/docker/build.sh, line 87 at r1 (raw file):

# Only check cppformat on Ubuntu, since it has req. clang-format version
if [ "${OS}" == "ubuntu"]; then
	CHECK_CPP_STYLE=ON;

nit: not sure if it's a problem but with this if we cannot disable checking CPP_STYLE for ubuntu. Maybe we should check if this variable is explicitly OFF first?

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft May 25, 2020 12:54
@lukaszstolarczuk lukaszstolarczuk force-pushed the bump-docker-images-versions branch from bf865f7 to b11d009 Compare May 26, 2020 20:33
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review May 26, 2020 20:33
Copy link
Copy Markdown
Member Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @igchor)


utils/docker/build.sh, line 87 at r1 (raw file):

Previously, igchor (Igor Chorążewicz) wrote…

nit: not sure if it's a problem but with this if we cannot disable checking CPP_STYLE for ubuntu. Maybe we should check if this variable is explicitly OFF first?

Done.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft May 27, 2020 12:16
@lukaszstolarczuk
Copy link
Copy Markdown
Member Author

lukaszstolarczuk commented Jun 17, 2020

images' versions will be updated to LTS versions on all branches.

This PR will be probably merged into stable-1.9

@lukaszstolarczuk
Copy link
Copy Markdown
Member Author

changes of this PR are covered already in #887 and we've changed approach for CHECK_CPP_STYLE (based on pmem/pmemkv@380cb14).

@lukaszstolarczuk lukaszstolarczuk deleted the bump-docker-images-versions branch September 23, 2020 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants