This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Merged
Conversation
Member
Author
|
Updating version of older docker images, for older branches (stable-1.*) is not always an easy job, because of dependencies... we need to discuss our approach. |
cdce797 to
07f2263
Compare
e8ed942 to
9d456ae
Compare
473b9ad to
d979771
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.5 #814 +/- ##
==============================================
- Coverage 90.77% 90.63% -0.15%
==============================================
Files 26 26
Lines 1052 1025 -27
==============================================
- Hits 955 929 -26
+ Misses 97 96 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
and set clang-format to fixed version (6.0).
fdc23df to
7c9aa11
Compare
igchor
approved these changes
Sep 11, 2020
Contributor
igchor
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, set clang-format to fixed version (6.0), bump Valgrind version, bump PMDK's patch version, and use ndctl from packages in CI (rather than installing from sources).
ref. to #737 - we decided to bump dockerimages on all branches.
This change is