Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

bump docker images versions#814

Merged
igchor merged 4 commits intopmem:stable-1.5from
lukaszstolarczuk:bump-dockerimages-to-lts
Sep 11, 2020
Merged

bump docker images versions#814
igchor merged 4 commits intopmem:stable-1.5from
lukaszstolarczuk:bump-dockerimages-to-lts

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Jul 24, 2020

  • bump Fedora version (28 -> 32)
  • Ubuntu is already set to LTS version (18.04)

Also, set clang-format to fixed version (6.0), bump Valgrind version, bump PMDK's patch version, and use ndctl from packages in CI (rather than installing from sources).

ref. to #737 - we decided to bump dockerimages on all branches.


This change is Reviewable

@lukaszstolarczuk lukaszstolarczuk changed the title bump docker images versions [TO DISCUSS] bump docker images versions Jul 27, 2020
@lukaszstolarczuk
Copy link
Copy Markdown
Member Author

Updating version of older docker images, for older branches (stable-1.*) is not always an easy job, because of dependencies... we need to discuss our approach.

@lukaszstolarczuk lukaszstolarczuk added the help wanted Help is required here label Jul 27, 2020
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft September 9, 2020 11:25
@lukaszstolarczuk lukaszstolarczuk changed the title [TO DISCUSS] bump docker images versions bump docker images versions Sep 9, 2020
@lukaszstolarczuk lukaszstolarczuk removed the help wanted Help is required here label Sep 9, 2020
@lukaszstolarczuk lukaszstolarczuk force-pushed the bump-dockerimages-to-lts branch 3 times, most recently from 473b9ad to d979771 Compare September 10, 2020 11:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2020

Codecov Report

Merging #814 into stable-1.5 will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.5     #814      +/-   ##
==============================================
- Coverage       90.77%   90.63%   -0.15%     
==============================================
  Files              26       26              
  Lines            1052     1025      -27     
==============================================
- Hits              955      929      -26     
+ Misses             97       96       -1     
Flag Coverage Δ
#tests_clang_debug_cpp17 61.93% <ø> (-29.53%) ⬇️
#tests_clang_release 61.46% <ø> (-28.86%) ⬇️
#tests_gcc_debug 93.61% <ø> (+0.20%) ⬆️
#tests_gcc_release_cpp17 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/detail/conversions.hpp 80.00% <0.00%> (-20.00%) ⬇️
include/libpmemobj++/make_persistent.hpp 76.19% <0.00%> (-14.29%) ⬇️
include/libpmemobj++/make_persistent_array.hpp 83.33% <0.00%> (-5.35%) ⬇️
include/libpmemobj++/condition_variable.hpp 82.66% <0.00%> (-2.67%) ⬇️
include/libpmemobj++/transaction.hpp 87.34% <0.00%> (-2.54%) ⬇️
include/libpmemobj++/detail/life.hpp 92.30% <0.00%> (-1.81%) ⬇️
...lude/libpmemobj++/make_persistent_array_atomic.hpp 94.73% <0.00%> (-0.51%) ⬇️
include/libpmemobj++/experimental/array.hpp 100.00% <0.00%> (ø)
.../libpmemobj++/experimental/contiguous_iterator.hpp 100.00% <0.00%> (ø)
include/libpmemobj++/persistent_ptr.hpp 97.19% <0.00%> (+1.74%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e5c45...7c9aa11. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review September 10, 2020 13:44
Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor merged commit 139116a into pmem:stable-1.5 Sep 11, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the bump-dockerimages-to-lts branch September 11, 2020 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants