Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Merge stable 1.7 into stable 1.8#882

Merged
lukaszstolarczuk merged 18 commits intopmem:stable-1.8from
lukaszstolarczuk:merge-stable-1.7-into-stable-1.8
Sep 23, 2020
Merged

Merge stable 1.7 into stable 1.8#882
lukaszstolarczuk merged 18 commits intopmem:stable-1.8from
lukaszstolarczuk:merge-stable-1.7-into-stable-1.8

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Sep 21, 2020

This change is Reviewable

lukaszstolarczuk and others added 18 commits September 9, 2020 21:11
and set clang-format to fixed version (6.0).
otherwise it will still use found (most likely, newer) clang-format.
…to-stable-1.6

Merge stable-1.5 into stable-1.6
…ocker-scripts

docker: make build- and push-image scripts more verbose
…to-stable-1.7

Merge stable-1.6 into stable-1.7
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2020

Codecov Report

Merging #882 into stable-1.8 will decrease coverage by 4.93%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.8     #882      +/-   ##
==============================================
- Coverage       97.06%   92.12%   -4.94%     
==============================================
  Files              34       34              
  Lines            4057     3659     -398     
==============================================
- Hits             3938     3371     -567     
- Misses            119      288     +169     
Flag Coverage Δ
#tests_clang_debug_cpp17 59.37% <ø> (-37.75%) ⬇️
#tests_gcc_debug 94.39% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/detail/conversions.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/libpmemobj++/detail/atomic_backoff.hpp 52.94% <0.00%> (-41.18%) ⬇️
include/libpmemobj++/timed_mutex.hpp 50.00% <0.00%> (-31.82%) ⬇️
include/libpmemobj++/pexceptions.hpp 50.00% <0.00%> (-30.77%) ⬇️
include/libpmemobj++/make_persistent.hpp 69.23% <0.00%> (-15.96%) ⬇️
include/libpmemobj++/container/vector.hpp 87.96% <0.00%> (-10.40%) ⬇️
include/libpmemobj++/condition_variable.hpp 70.88% <0.00%> (-10.13%) ⬇️
include/libpmemobj++/shared_mutex.hpp 76.08% <0.00%> (-9.33%) ⬇️
include/libpmemobj++/make_persistent_atomic.hpp 90.90% <0.00%> (-9.10%) ⬇️
include/libpmemobj++/mutex.hpp 71.42% <0.00%> (-8.58%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3cecd...d0d89e1. Read the comment docs.

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 11 files reviewed, all discussions resolved

@lukaszstolarczuk lukaszstolarczuk force-pushed the merge-stable-1.7-into-stable-1.8 branch from 8c1dd11 to d0d89e1 Compare September 21, 2020 14:28
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft September 22, 2020 09:42
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review September 22, 2020 14:40
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft September 22, 2020 15:06
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review September 22, 2020 19:52
Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 8 files at r4, 4 of 10 files at r5, 4 of 5 files at r7.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukaszstolarczuk lukaszstolarczuk merged commit 197dcda into pmem:stable-1.8 Sep 23, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the merge-stable-1.7-into-stable-1.8 branch September 23, 2020 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants