CI: always build and push docker images#935
CI: always build and push docker images#935lukaszstolarczuk wants to merge 1 commit intopmem:stable-1.5from
Conversation
karczex
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
On stable branches we don't commit much, so this will hardly impact usage of our CI, and since we always rebuild, script 'pull-or-rebuild.sh' is no longer necessary.
bd66ee0 to
3ffa1f2
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.5 #935 +/- ##
==============================================
+ Coverage 90.32% 90.43% +0.11%
==============================================
Files 26 26
Lines 1023 1025 +2
==============================================
+ Hits 924 927 +3
+ Misses 99 98 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@lukaszstolarczuk |
igchor
left a comment
There was a problem hiding this comment.
TBH, I'd prefer https://github.com/pmem/libpmemobj-cpp/pull/929/files
With this approach we'll have to resolve merge conflicts for each new stable branch when merging with master.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
|
#929 is most likely the way we go to solve our problem. |
On stable branches we don't commit much, so this will hardly impact
usage of our CI, and since we always rebuild, script 'pull-or-rebuild.sh'
is no longer necessary.
It's an alternative for #929 :
This change is