example F: update Web description#10
Conversation
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamianDuy)
templates/examples/F/body.tmpl line 70 at r1 (raw file):
<p> A simple C program using <b>libpmem2</b> is shown below. The correct machanism for flushing the data
machanism misspell
templates/examples/F/body.tmpl line 71 at r1 (raw file):
<p> A simple C program using <b>libpmem2</b> is shown below. The correct machanism for flushing the data into user storage is automatically chosen by <b>libpmem2</b>. To obtain the correct function for flushing
user storage -> (underlaying) medium (?)
templates/examples/F/body.tmpl line 74 at r1 (raw file):
from user space, <tt><a href="https://pmem.io/pmdk/manpages/linux/master/libpmem2/pmem2_get_persist_fn.3/" target="_new">pmem2_get_persist_fn()</a></tt> is used. <p>
perhaps we should describe here a little, when to call this function
7c9615f to
b105d45
Compare
DamianDuy
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
templates/examples/F/body.tmpl line 70 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
machanismmisspell
Done.
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @DamianDuy)
wlemkows
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @DamianDuy)
wlemkows
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamianDuy)
templates/examples/F/body.tmpl line 74 at r2 (raw file):
from user space, <tt><a href="https://pmem.io/pmdk/manpages/linux/master/libpmem2/pmem2_get_persist_fn.3/" target="_new">pmem2_get_persist_fn()</a></tt> is used. It returns a pointer to the function, which efficiently persists the data in the range owned by the map. As can be seen in the example below, we call the obtained function with the provided <i>map</i> argument after our data was stored to the persistent memory (see line 93). The obtained function
I am not sure if those line numbers are correct (?)
b105d45 to
f4c725e
Compare
f4c725e to
65a6901
Compare
DamianDuy
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk and @wlemkows)
templates/examples/F/body.tmpl line 74 at r2 (raw file):
Previously, wlemkows (Weronika Lewandowska) wrote…
I am not sure if those line numbers are correct (?)
I referred to the line where data was stored into memory instead of the line where the described pmem2_get_persist_fn() function was actually called, which was confusing. I've changed it now.
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
👍
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wlemkows)
Matching updated code in: pmemhackathon/hackathon#5
This change is