Skip to content

Update example F (libpmem to libpmem2)#5

Merged
lukaszstolarczuk merged 1 commit intopmemhackathon:mainfrom
DamianDuy:updateExample
Sep 26, 2022
Merged

Update example F (libpmem to libpmem2)#5
lukaszstolarczuk merged 1 commit intopmemhackathon:mainfrom
DamianDuy:updateExample

Conversation

@DamianDuy
Copy link
Copy Markdown
Contributor

@DamianDuy DamianDuy commented Sep 19, 2022

Code content for pmemhackathon/hackathon.web#10

// Migrated from: pmemhackathon/2021-04-21#4


This change is Reviewable

Copy link
Copy Markdown
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamianDuy)

a discussion (no related file):
did you execute this example (at least) on the docker image defined in hackathon.web repo?


Copy link
Copy Markdown
Contributor Author

@DamianDuy DamianDuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

a discussion (no related file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

did you execute this example (at least) on the docker image defined in hackathon.web repo?

Yes, I've managed to by now.


Copy link
Copy Markdown
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamianDuy)

a discussion (no related file):

Previously, DamianDuy (Damian Duy) wrote…

Yes, I've managed to by now.

👍


@lukaszstolarczuk lukaszstolarczuk merged commit f69c3eb into pmemhackathon:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants