chore: drop dead IE11 MSStream check in iPadOS detection#160
Merged
Conversation
`!window.MSStream` was imported from a circa-2013 Stack Overflow snippet that used it to exclude Internet Explorer on Windows Phone from being detected as iOS. It was never reachable under the `MacIntel` branch — IE never ran on macOS — so the guard was dead the day it was written. IE itself has been EOL since June 2022. Removing it also drops the `@ts-expect-error` it justified. Also inlines a brief note on why `navigator.platform` (deprecated on MDN) is still used here: `navigator.userAgentData.platform` is Chromium-only and doesn't expose the iPadOS-as-MacIntel masquerade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
!window.MSStreamclause in the iPadOS detection branch was imported from a circa-2013 Stack Overflow snippet that used it to exclude Internet Explorer on Windows Phone from being detected as iOS. It was never reachable under the `platform === 'MacIntel'` branch — IE never ran on macOS — so the guard was dead the day it was added. IE itself has been EOL since June 2022.Removing it also drops the `@ts-expect-error` comment it justified (since `window.MSStream` isn't in the DOM lib types).
Bonus: comment upgrades
Diff
Test plan