Skip to content

Conversation

@abernier
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the build toolchain from Vite 5 to Vite 7, along with updating the corresponding React plugin and raising the minimum Node.js version requirement.

  • Vite upgraded from ^5.4.0 to ^7.3.0 (major version jump)
  • @vitejs/plugin-react upgraded from ^4.3.1 to ^5.1.2 (major version jump)
  • Node.js engine requirement raised from >=18 to >=20
  • npm engine requirement added: >=10

Reviewed changes

Copilot reviewed 157 out of 158 changed files in this pull request and generated no comments.

File Description
package-lock.json Updated Vite to 7.3.0, @vitejs/plugin-react to 5.1.2, raised Node.js requirement to >=20, added npm >=10 requirement, removed nested dependency entries for deprecated packages
demos/*/package.json Updated vite and @vitejs/plugin-react versions across all demo packages to match the new versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abernier
Copy link
Member Author

@copilot ci build failed with 3 failed:

 Tasks:    152 successful, 155 total
Cached:    0 cached, 155 total
  Time:    11m21.021s 
Failed:    @demo/csg-bunny-usegroups#build2, @demo/csg-operations-rapier-physics#build2, @demo/multiple-views-with-uniform-controls#build2

can you check in more deaths and understand why, eventually a fix?

Copy link
Contributor

Copilot AI commented Dec 29, 2025

@abernier I've opened a new pull request, #93, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Initial investigation of build failures

Co-authored-by: abernier <76580+abernier@users.noreply.github.com>

* Fix build failures for CSG and multiple-views demos

Co-authored-by: abernier <76580+abernier@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
@abernier abernier merged commit 476e815 into main Dec 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants