CDL implementation for tone mapping #723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #584
Description
This PR implements CDL for AgX tone mapping. It's based on mrdoob/three.js#27618 and mrdoob/three.js#29510.
The API looks like this:
I've also included the preset from Needle Engine that @hybridherbst posted here for good measure.
I had hoped that CDL would eventually land in
three, and not just for TSL because it would've made the integration process much easier. Now it's a bit on the messier side since it requires shader chunk manipulation.Feedback is welcome @donmccurdy, @hybridherbst and anyone else who might be interested.