chore(ci): trim redundant node matrix and adopt .nvmrc in tests workflow#2437
Merged
Conversation
- Drop the Node matrix from jobs where two Node versions produce identical signal (build, test-types, test-e2e, test-published-artifact, are-the-types-wrong). - Keep test-unit on Node 22.x and 24.x to catch Vitest/Playwright tooling regressions on the next LTS. - Pin test-e2e to Node 24.x as a forward-compat canary. - Use node-version-file '.nvmrc' for jobs that just need the project's Node, so the version stays consistent with local dev. - Add a missing setup-node step to are-the-types-wrong.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several jobs in
tests.ymlwere running acrossnode: ['22.x', '24.x']even though the underlying tool (tsc, tsup, npx) produces the same result on both versions. This trims the matrix to only the jobs where dual-Node coverage actually catches something, and switches single-Node jobs to read from.nvmrcso they track the project's pinned version.What stays on multiple Node versions
test-unit— Vitest + Playwright execute on Node, so this is the canary for tooling regressions on the next LTS. Keeps 22.x + 24.x.What changed
build,test-types,test-published-artifact,are-the-types-wrongnow usenode-version-file: '.nvmrc'. No behavioural difference, single job instead of two.test-e2ecollapses to a single Node version, pinned to24.xas a forward-compat canary (next-LTS signal; the unit suite already covers current LTS).are-the-types-wrongpreviously had anode: ['22.x']matrix wrapper but nosetup-nodestep at all — added one using.nvmrc.Net effect
Roughly 7 fewer jobs per PR, no loss of meaningful signal.