mpl: Improved check for AVX/AVX512F support #7699
Merged
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
Author
|
test:mpich/ch4/most |
Contributor
Author
|
This does resolve the issue, but perhaps the compiler warning check for |
Contributor
I agree |
PAC_C_CHECK_COMPILER_OPTION checks for warning messages, but those can be silenced by the user e.g. with clang's -Qunused-arguments. Try to compile a simple program using the extensions needed by MPL for a more robust test for this functionality.
Contributor
Author
|
test:mpich/ch4/most |
|
Do you have an ETA for the RC2, please? |
Contributor
Author
I think today? cc @hzhou |
Contributor
Oops. I'll do it this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PAC_C_CHECK_COMPILER_OPTION checks for warning messages, but those can
be silenced by the user e.g. with clang's -Qunused-arguments. Try to
compile a simple program using the extensions needed by MPL for a more
robust test for this functionality.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.