configure: check whether complex is available for CXX #7720
+22
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalcinl
reviewed
Feb 6, 2026
| if test "$len" = 64 ; then | ||
| # long double is an alias of double, e.g. arm64 | ||
| internal_type=MPIR_COMPLEX$len | ||
| if test "$ac_cv_sizeof_Complex" -gt 0 ; then |
Contributor
There was a problem hiding this comment.
@hzhou Are you using the right comparison operator? I'm not great at shell programming, but I would have expected to see -eq here.
Suggested change
| if test "$ac_cv_sizeof_Complex" -gt 0 ; then | |
| if test "$ac_cv_sizeof_Complex" -eq 0 ; then |
Contributor
Author
There was a problem hiding this comment.
Oh, I swapped the logic as I copy/paste :( . Thanks for noticing!
hzhou
force-pushed
the
2602_cxx_complex
branch
from
23714e4 to
b9c79e9
Compare
dalcinl
approved these changes
Feb 6, 2026
raffenet
approved these changes
Feb 11, 2026
hzhou
force-pushed
the
2602_cxx_complex
branch
from
b9c79e9 to
6d3013e
Compare
Contributor
Author
|
test:mpich/ch3/most |
Don't assume the complex types are always available in CXX.
hzhou
force-pushed
the
2602_cxx_complex
branch
from
6d3013e to
d59de01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Don't assume the complex types are always available in CXX.
Potentially fixes #7719
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.