Fix/publisher concurrency#116
Merged
Merged
Conversation
|
coverage: 81.22% (-0.5%) from 81.763% — fix/publisher-concurrency into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publisher is now concurrency-safe.
Publisher.Publishpreviously shared a single*amqp.Channelwithout synchronization, which could corrupt the AMQP frame stream when called from multiple goroutines. Publishes are now serialized with a mutex. Added a regression test to assert this (TestPublisherConcurrentPublish)RabbitMQ 4 support. Bumped the test broker to
rabbitmq:4-managementand fixed retry counting against v4. In v4,basic.nackwith requeue on a quorum queue no longer incrementsx-delivery-countbut it increments the newx-acquired-countheader instead.shouldRetrynow readsx-acquired-countfirst and falls back tox-delivery-count, so retry limits work on both v3 and v4 brokers.Dependency update.