docs(README): point users to the successor pnpm/setup action - #282
Conversation
The pnpm setup action has moved to `pnpm/setup`, which installs pnpm v11+ as a self-contained native executable and can install a JavaScript runtime (Node.js, Bun, or Deno) in the same step, replacing `actions/setup-node`. Add a notice at the top of the README, a migration section with a before/after workflow example and an input/output mapping table, and mention the successor in the Notes section. The rest of the docs stay intact since `pnpm/action-setup` remains the way to install pnpm v10 and older. Signed-off-by: Kevin Cui <bh@bugs.cc>
📝 WalkthroughWalkthroughREADME.md documents Changespnpm setup migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by Qododocs(README): add migration guidance to successor pnpm/setup action
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 1-7: Update the README.md callout block by prefixing the blank
separator line after the pnpm v10 guidance with “>”, keeping the entire
multi-paragraph notice within the same blockquote and satisfying markdownlint
MD028.
- Line 237: Update the README sentence to use “set up” as the verb and split the
comma-spliced sentence into separate sentences while preserving the existing
guidance and links.
- Around line 35-38: Update the migration example’s pnpm/setup configuration to
explicitly specify pnpm version 11, or include the required package.json
packageManager upgrade before removing the version input; ensure the “After”
workflow never leaves pnpm unresolved or below v11.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2fe58497-d91e-42af-8555-6842fadd2a91
📒 Files selected for processing (1)
README.md
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Standalone Windows self-update (PATH regression)
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~53-~53: The official name of this software platform is spelled with a capital “H”.
Context: ...b token for release lookup; defaults to ${{ github.token }} and rarely needs to be set. |...
(GITHUB)
🪛 markdownlint-cli2 (0.23.1)
README.md
[warning] 7-7: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🔇 Additional comments (2)
README.md (2)
16-23: LGTM!
41-54: LGTM!
|
make the changes suggested by coderabbit |
Add an explicit version: 11 to the migration example and note when the input can be omitted, since pnpm/setup requires pnpm v11+ and a repo migrating from version: 10 may have no packageManager field or one that pins v10. Move the v2 upgrade warning below the page title so the two callouts are no longer adjacent blockquotes (markdownlint MD028), keeping the successor notice and the legacy warning as separate blocks. Fix the comma splice and use "set up" as the verb in the Notes section. Signed-off-by: Kevin Cui <bh@bugs.cc>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
56-56: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winRemove the
tokenmigration row.This table describes
pnpm/setup@v1, but that action version does not declare atokeninput. Remove the row unless the supported release version adds and documents it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 56, Remove the `token` row from the `pnpm/setup@v1` migration table in README.md; do not document this input unless the supported action version declares and documents it.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.md`:
- Line 56: Remove the `token` row from the `pnpm/setup@v1` migration table in
README.md; do not document this input unless the supported action version
declares and documents it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e9ab4180-136f-40d9-b3dd-62efa61c348d
📒 Files selected for processing (1)
README.md
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: Smoke (windows / v9.15.5)
- GitHub Check: Standalone Windows self-update (PATH regression)
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~14-~14: Consider using a different verb for a more formal wording.
Context: ...lease, upgrade to the latest version to fix any issues. ## Migrating to pnpm/setup...
(FIX_RESOLVE)
🔇 Additional comments (4)
README.md (4)
1-7: LGTM!
12-14: LGTM!
16-55: LGTM!
240-240: LGTM!
b347683 to
eaee327
Compare
The pnpm setup action has a successor:
pnpm/setupinstalls pnpm v11+ as a self-contained native executable and can install a JavaScript runtime (Node.js, Bun, or Deno) in the same step, replacingactions/setup-node. This README didn't mention it, so users landing here had no pointer to the new action or guidance on moving over.This adds an important notice at the top pointing to the successor, a "Migrating to pnpm/setup" section with a before/after workflow example and an input/output mapping table (
run_installbecomesinstall, snake_case inputs renamed to kebab-case,standaloneremoved, newruntimeandtokeninputs), and a short mention in the Notes section. Everything else stays intact sincepnpm/action-setupremains the way to install pnpm v10 and older.Summary by CodeRabbit
pnpm/setupfor pnpm v11 and later.