fix(vue-vapor): guard node.children access#142
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a Vue Vapor renderer edge case where switching conditional content can yield a text-node-shaped value that lacks a children property, causing traversal code to throw during retention/sweep checks.
Changes:
- Adds a guard in
subtreeHasRetained()to avoid accessingnode.childrenwhen it’s missing at runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
365
to
373
| function subtreeHasRetained(node: NodeMirror): boolean { | ||
| if (!node) return false; | ||
| if (retained.has(node)) return true; | ||
| for (let i = 0; i < node.children.length; i++) { | ||
| if (subtreeHasRetained(node.children[i])) return true; | ||
| if (node.children) { | ||
| for (let i = 0; i < node.children.length; i++) { | ||
| if (subtreeHasRetained(node.children[i])) return true; | ||
| } | ||
| } | ||
| return false; |
doodlewind
added a commit
that referenced
this pull request
Jul 22, 2026
…port work) Conflicts were squash-merge echoes of the launcher PR plus the ESP32 viewport refactor: kept the .pocket package side everywhere it owned the hunk, took main's join()-style paths and SimViewportOptions, and merged the test chain as the union of both additions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching
tab.value, a null/undefined node will be rendered as a text node, which does not have achildrenproperty.