feat(build): --font-regular/--font-bold source overrides#155
Merged
Conversation
Lets a target bake subset or alternative TTFs without replacing the shared assets in the tree — the ESP32-P4 lyrics firmware uses a subset CJK font to fit the app partition, while desktop/web builds keep the stock fonts.
doodlewind
approved these changes
Jul 24, 2026
doodlewind
left a comment
doodlewind
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed and validated locally on a merge with current main:
bun test tests/font-bake.test.tspasses; explicit--font-regular/--font-bold=assets/fonts/Inter-*.ttfproduces byte-identical output to the default build (default path provably untouched), and a genuinely different TTF changes the baked pak — the option flows through end to end.- Flag parsing and one-arg
resolvePath(cwd-relative) match the existing--plan/--project-root/--outdirconventions, andbake-font.ts's?? DEFAULT_*keeps Inter as the fallback. - Nit, non-blocking: a bad path surfaces as a raw ENOENT from
loadFont— a one-line existence check with a friendly message would be nicer.
Thanks for also documenting the pre-existing --density flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--font-regular=<path>and--font-bold=<path>CLI flags let a target build with alternative TTF sources without replacing the shared Inter fonts inassets/fonts/.Motivation
framework/compiler/bake-font.tsalready acceptedregularTtf/boldTtfinBakeOptions, buttools/build.tsnever wired them up to CLI args.Use case
The ESP32-P4 lyrics firmware needs a subset CJK font to fit the app partition, while desktop/web builds keep the stock Inter fonts.
Changes
tools/build.ts— 9 lines added:--font-regular=and--font-bold=argument parsingbakeAtlases({ regularTtf, boldTtf })