feat(symbian): package private mass-storage data - #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--mass-storage-data-root <dir>for application-specific Symbian coresE:\private\<UID>\data\<relative>and record{path, bytes, sha256}in receipt schema 3Why
Large native assets must not be embedded in
app.pak: the Symbian host and QuickJS can otherwise duplicate the full pack in the E7's small process heap. This gives custom native cores a generic, receipt-pinned data channel while keeping the stock runtime and launcher contracts unchanged.Impact
Existing apps continue to receive an empty
dataarray. Only callers that explicitly combine--core-librarywith--mass-storage-data-rootinstall external files, and the native core remains responsible for opening them.Validation
bun node_modules/typescript/bin/tsc --noEmitbash -n tools/symbian/container/pocketjs-symbian-build-appbun test tests/symbian-data.test.ts— 3/3bun test tests/symbian-runtime.test.ts— 13/13bun test tests/symbian-toolchain.test.ts --test-name-pattern '^(?!.*CODA launch wire)'— 13/13bun test tests/npm-package.test.ts— 3/3git diff --checkThe excluded existing CODA launch fixture is locally blocked before test logic because endpoint security stalls its compiled executable in dyld; the mass-storage patch does not touch CODA.