fix(symbian): normalize E7 letter keys - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Qt 4.7's Symbian backend forwards ordinary character keysyms directly. On the Nokia E7, an unshifted physical
Warrives as lowercase ASCIIw, while the PocketJS host only matched uppercaseQt::Key_W(and likewise for A/S/D/R/E). Special keys such as Enter, Backspace, and arrows use Qt's special-key translation and therefore continued to work.Impact
Unshifted E7 letter controls now reach native extensions and standard PocketJS button mappings. This restores OpenStrike WASD movement, R reload, and E fire without adding application-specific handling.
Validation
bunx tsc --noEmitbun test tests/symbian-runtime.test.ts(14/14)bun test tests/npm-package.test.ts(3/3)git diff --checkarm-none-symbianelf-g++ -std=gnu++98 -WerrorcompileReal-device verification will follow through the OpenStrike 0.3.1 package before this PocketJS target's hardware acceptance is closed.