fix(vrm): normalize VRMA humanoid rotations - #207
Draft
doodlewind wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous loader copied raw local VRMA quaternions directly (apart from the VRM 1 to VRM 0 facing flip). Raw rest axes differ between rigs, so wrists, hands, ankles, and feet were visibly twisted even though humanoid bone names matched.
This is a generic
pocket-vrmcorrection with no Persona-specific runtime branch. The Persona fixture is optional, git-ignored test data used only as an independent three-vrm golden.Validation
cargo test --manifest-path engine/Cargo.toml -p pocket-vrm(19 unit + 6 fixture tests)cargo clippy --manifest-path engine/Cargo.toml -p pocket-vrm --all-targets -- -D warningsrustfmt --edition 2024 --check engine/crates/pocket-vrm/src/vrma.rs engine/crates/pocket-vrm/tests/fixtures.rsgit diff --checkStack
This draft currently targets
creative-educationonly because it is built on the generic window visibility commit in #204. The VRMA change is independent and should be retargeted tomainafter #204 lands.