fix(gesture): axis dominance defers instead of killing — real thumbs arc - #215
Merged
Conversation
The pan-axis verdict fired ONCE, at the first frame total travel crossed slop (6 logical px = 24 Vita panel px), and marked the recognizer PAN_DEAD for the contact's lifetime. A script moves in a pure line and always passed; a real thumb lands with wobble and arcs, so the wrong axis often wins those first pixels — on hardware the motions pager simply never fired (sim AND the scripted Vita3K run both turned the page; only from_reports input showed the failure). The verdict is now re-evaluated every unclaimed frame: the recognizer claims the moment its locked axis dominates, and a drag whose dominant axis never matches still never pans it — a vertical scroll cannot turn a horizontal pager. PAN_DEAD retires with the single-shot rule. This also repairs the same class for vertical lists under diagonal-start flicks. Two new unit cases pin the thumb profile (wobble-first swipe pans; pure vertical never does). Validated: gesture 21, canonical chain 0 fail, 54 web goldens byte-exact, im-touch + im-rowtap Vita3K byte-exact (pure-line scripts are behavior-identical under deferral). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
doodlewind
marked this pull request as ready for review
August 4, 2026 07:37
doodlewind
added a commit
that referenced
this pull request
Aug 4, 2026
The pure-line swipe script passed on the broken axis verdict everywhere; only hardware failed. The spec's touch track now lands with an 8px vertical wobble before the horizontal sweep — the profile that turns the page ONLY through #215's deferred-dominance claim (verified both ways: 1/4 on the pre-fix framework, 2/4 with it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardware-only bug, third of its kind, same lesson: scripts move in pure lines; thumbs don't.
The pan-axis verdict fired once at the first slop crossing (6 logical px = 24 panel px) and permanently killed the recognizer for that contact — landing wobble routinely hands the wrong axis those first pixels, so the motions pager never fired on a real Vita while sim AND scripted Vita3K both passed.
Now the verdict re-evaluates every unclaimed frame: claim when the locked axis dominates; never claim if it never does (a vertical scroll still can't turn a horizontal pager). Also repairs diagonal-start flicks on vertical lists.
PAN_DEADretires.Pinned by two thumb-profile unit cases; chain 0 fail, 54 web goldens + im Vita3K byte-exact.
🤖 Generated with Claude Code